DRYer code, less indents, default directory#38
Open
B7th wants to merge 4 commits intofairfieldt:masterfrom
B7th:patch-2
Open
DRYer code, less indents, default directory#38B7th wants to merge 4 commits intofairfieldt:masterfrom B7th:patch-2
B7th wants to merge 4 commits intofairfieldt:masterfrom
B7th:patch-2
Conversation
added 4 commits
August 13, 2016 03:56
Added a bit of functionality to the code as well as making it more readable at least in appearance.
`is` and `isnt` instead of `==` and `!=`, `throw` outside of if/else, added/changed comments
Owner
|
Hey, thanks for the pull! It's a bit hard to look at with all the whitespace changes - could you move the whitespace changes to their own pull (I'm definitely open to the change, but I'd really like to do it separately) |
Contributor
Author
|
Sure I made a new patch on another pull request that will do the whitespace, and I think once you accept it this pull should be easier to read, agreed with you on that. Let me know what you think of the changes! |
Owner
|
Thanks! I'll try to take a look at this stuff tonight. |
Owner
|
I merged the first patch, minus the require changes - I'd prefer to keep the explicit require calls. Can you update this pull to remove the whitespace changes? I'd love to get it in. |
Contributor
Author
|
Sure! I made a new pull to keep things separate, I hope this helps :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a bit of functionality by making the directory of the file being concatenated the default one, as well as making it more readable at least in appearance, using right handed expressions, getting rid of doublings as well as curly braces.