feat(function): Add Spark dayname function#15957
Closed
yaooqinn wants to merge 5 commits intofacebookincubator:mainfrom
Closed
feat(function): Add Spark dayname function#15957yaooqinn wants to merge 5 commits intofacebookincubator:mainfrom
yaooqinn wants to merge 5 commits intofacebookincubator:mainfrom
Conversation
yaooqinn
requested review from
jinchengchenghh,
rui-mo and
zhli1142015
as code owners
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
meta-cla
Bot
added
the
CLA Signed
yaooqinn
changed the title
zhli1142015
approved these changes
Jan 12, 2026
yaooqinn
commented
Jan 12, 2026
| :spark:func:`dayofmonth` :spark:func:`map_values` :spark:func:`uuid` | ||
| :spark:func:`dayofweek` :spark:func:`map_zip_with` :spark:func:`varchar_type_write_side_check` | ||
| :spark:func:`dayofyear` :spark:func:`mask` :spark:func:`week_of_year` | ||
| :spark:func:`dayname` :spark:func:`map_values` :spark:func:`uuid` |
Contributor
There was a problem hiding this comment.
Please don't update this file, weekly job will does the update
Contributor
Author
There was a problem hiding this comment.
This helps a lot. Thank you @jinchengchenghh
yaooqinn
force-pushed
the
feature/add-dayname-function
branch
from
47a379a to
536ba46
Compare
| EXPECT_EQ("Fri", dayName(parseDate("2023-08-25"))); | ||
| EXPECT_EQ("Sat", dayName(parseDate("2023-08-26"))); | ||
| EXPECT_EQ( | ||
| "Fri", dayName(parseDate("1582-10-15"))); // Gregorian calendar start |
Contributor
There was a problem hiding this comment.
The comment should end with .
yaooqinn
commented
Jan 12, 2026
Implements the dayname() function that returns the three-letter abbreviated day name (Sun, Mon, Tue, Wed, Thu, Fri, Sat) from a given date, matching Apache Spark's behavior with Locale.US.
Format long test line in DateTimeFunctionsTest.cpp to align with project formatting guidelines (clang-format).
zhli1142015
force-pushed
the
feature/add-dayname-function
branch
from
1d786ff to
60ff08e
Compare
zhli1142015
added
the
ready-to-merge
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this in D90602088. |
|
@kevinwilfong merged this pull request in d11f8e4. |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
dayname()function for Spark SQL compatibility that returns the three-letter abbreviated day name (Sun, Mon, Tue, Wed, Thu, Fri, Sat) from a given date.