This repository was archived by the owner on Apr 30, 2023. It is now read-only.
Fix PHP8.1 Deprecated Functionality: strtolower(): Passing null#132
Open
mihaimatei wants to merge 1 commit intofacebookarchive:mainfrom
Open
Fix PHP8.1 Deprecated Functionality: strtolower(): Passing null#132mihaimatei wants to merge 1 commit intofacebookarchive:mainfrom
mihaimatei wants to merge 1 commit intofacebookarchive:mainfrom
Conversation
…rameter facebookarchive#1 () of type string is deprecated
facebook-github-bot
added
the
CLA Signed
1 task
Contributor
|
Hi @mihaimatei, thanks for your PR – good catch. We have already fixed the issue in a very similar way, will push the fix shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes error
Deprecated Functionality: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in vendor/facebook/facebook-for-magento2/Helper/MagentoDataHelper.php on line 481by casting the parameter passed to strtolower to string.