[compiler] Fix refs lint false positives for JSX ref props#36416
Open
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Open
[compiler] Fix refs lint false positives for JSX ref props#36416raashish1601 wants to merge 1 commit intofacebook:mainfrom
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The refs lint rule was aliasing non-current property loads back to their parent object. When a JSX ref attribute inferred
props.ref,props.buttonRef, orgroupRefs.group1as a ref, the parent object was then treated as a ref too, which made sibling props or sibling ref entries look likeref.currentaccesses during render.This keeps property-load values separate in the ref validation environment so JSX ref forwarding remains valid while direct
props.ref.currentreads still report.Fixes #35575
Fixes #34775
Fixes #35813
Fixes #35997
How did you test this change?
corepack yarn --cwd packages/eslint-plugin-react-hooks build:compilercorepack yarn --cwd packages/eslint-plugin-react-hooks jest ReactCompilerRuleTypescript-test --runInBandcorepack yarn --cwd packages/eslint-plugin-react-hooks typecheckgit diff --check