Add props object location callback fixture#36393
Open
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Open
Add props object location callback fixture#36393raashish1601 wants to merge 1 commit intofacebook:mainfrom
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
location.pathnamewindow.locationfrom the props object #31264Why
The reported props-object callback case now compiles on current main. This fixture locks in the behavior so object-spread JSX props do not regress relative to the inline JSX callback form.
Covers #31264.
Test Plan
corepack yarn workspace snap run snap --update --pattern props-object-with-location-callback --synccorepack yarn workspace snap run snap --pattern props-object-with-location-callback --synccorepack yarn workspace babel-plugin-react-compiler run lint -- --quietcorepack yarn prettier