Add createElement ref prop compiler fixture#36391
Open
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Open
Add createElement ref prop compiler fixture#36391raashish1601 wants to merge 1 commit intofacebook:mainfrom
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React.createElement("canvas", {ref})React.createElement(..., { ref })#31357 with successful output/evalWhy
The reported createElement/ref case now compiles on current main. This fixture locks in that behavior so
React.createElementdoes not regress relative to the JSX<canvas ref={ref} />case.Covers #31357.
Test Plan
corepack yarn workspace snap run snap --update --pattern createElement-ref-prop --synccorepack yarn workspace snap run snap --pattern createElement-ref-prop --synccorepack yarn workspace babel-plugin-react-compiler run lint -- --quietcorepack yarn prettier