Preserve computed object method keys#36389
Open
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Open
Preserve computed object method keys#36389raashish1601 wants to merge 1 commit intofacebook:mainfrom
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Object properties already forward the computed-key flag to Babel codegen, but object methods always passed
false. That caused computed method shorthand like{[computedKey]() {}}to print as{computedKey() {}}, changing the property name.Fixes #35203.
Test Plan
corepack yarn workspace snap run buildcorepack yarn workspace snap run snap --update --pattern computed-object-method-key --synccorepack yarn workspace snap run snap --pattern computed-object-method-key --synccorepack yarn workspace babel-plugin-react-compiler run lint -- --quietcorepack yarn prettier