[flow] Migrate type param bounds to extends syntax in ReactNativeTypes#35996
Draft
marcoww6 wants to merge 1 commit intofacebook:mainfrom
Draft
[flow] Migrate type param bounds to extends syntax in ReactNativeTypes#35996marcoww6 wants to merge 1 commit intofacebook:mainfrom
marcoww6 wants to merge 1 commit intofacebook:mainfrom
Conversation
…Types Flow's type parameter bound syntax `<T: Type>` has been deprecated in favor of `<T extends Type>`. This updates the 5 occurrences in ReactNativeTypes.js to use the new syntax. This is the source file that gets synced to react-native-github at Libraries/Renderer/shims/ReactNativeTypes.js via the build pipeline.
|
Comparing: 014138d...38423fd Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<T: Type>to<T extends Type>inReactNativeTypes.jsreact-native-github/Libraries/Renderer/shims/ReactNativeTypes.jsvia the build pipelineContext
D95907848 codemodded the synced copy in fbsource, but reviewer noted this file is synced from the React repo and must be changed here first (see PR #35989 comment).
Test plan
InspectorDataGetter,ReactNativeType.findHostInstance_DEPRECATED,ReactNativeType.findNodeHandle,ReactFabricType.findHostInstance_DEPRECATED,ReactFabricType.findNodeHandle)flow-remove-types