[DevTools] Only schedule a single update per Supense when changing timeline#35927
Open
eps1lon wants to merge 2 commits intofacebook:mainfrom
Conversation
github-actions
bot
added
the
React Core Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the Suspense timeline milestone was brute force. We sent the Fiber to each renderer for update. Not only is that wasteful, it can also break React if the Fibers from one renderer were not compatible with another renderer.
E.g. scheduling an update on a Fiber from React canary with React experimental would crash. Instead of
pendingIndicatorbeingnull | () => {}, React would seeundefinedsincependingIndicatorsimply doesn't exist in React canary.Test plan
Before:
CleanShot.2026-02-28.at.17.02.27.mp4
After:
CleanShot.2026-02-28.at.16.59.45.mp4