Skip to content

fix: correct private field type in react-devtools-fusebox package.json #35904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sudip-kumar-prasad wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −7
Open

fix: correct private field type in react-devtools-fusebox package.json #35904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a36b7c0
fix: correct private field type in react-devtools-fusebox package.json
sudip-kumar-prasad Feb 25, 2026
2d59cb2
fix(compiler): correct private field type in react-forgive packages
sudip-kumar-prasad Feb 25, 2026
086e51f
Merge branch 'main' into fix/react-devtools-fusebox-private-field
sudip-kumar-prasad Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/packages/react-forgive/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"private": "true",
"private": true,
"name": "react-forgive-client",
"version": "0.0.0",
"description": "Experimental LSP client",
Expand All @@ -19,4 +19,4 @@
"devDependencies": {
"@types/vscode": "^1.95.0"
}
}
}
4 changes: 2 additions & 2 deletions compiler/packages/react-forgive/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"private": "true",
"private": true,
"name": "react-forgive-server",
"version": "0.0.0",
"description": "Experimental LSP server",
Expand All @@ -22,4 +22,4 @@
"vscode-languageserver": "^9.0.1",
"vscode-languageserver-textdocument": "^1.0.12"
}
}
}
8 changes: 5 additions & 3 deletions packages/react-devtools-fusebox/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
{
"name": "react-devtools-fusebox",
"version": "0.0.0",
"private": "true",
"private": true,
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR correctly fixes the "private" field type in react-devtools-fusebox package.json. However, the same issue exists in two other package.json files:

  • compiler/packages/react-forgive/client/package.json (line 2)
  • compiler/packages/react-forgive/server/package.json (line 2)

Both files use "private": "true" (string) instead of "private": true (boolean). Consider fixing these as well to ensure consistency across the codebase and full compliance with the npm specification.

Copilot uses AI. Check for mistakes.
"license": "MIT",
"files": ["dist"],
"files": [
"dist"
],
"scripts": {
"build:frontend:copy-types": "cp src/*.d.ts dist/",
"build:frontend:local": "cross-env NODE_ENV=development webpack --config webpack.config.frontend.js && yarn build:frontend:copy-types",
Expand All @@ -20,4 +22,4 @@
"webpack-cli": "^5.1.1",
"workerize-loader": "^2.0.2"
}
}
}