Skip to content

VirtualizedListCellRenderer: hoist zIndex from renderItem element#56981

Open
siddeshgawande wants to merge 1 commit into
facebook:mainfrom
siddeshgawande:fix/flatlist-zindex-18616
Open

VirtualizedListCellRenderer: hoist zIndex from renderItem element#56981
siddeshgawande wants to merge 1 commit into
facebook:mainfrom
siddeshgawande:fix/flatlist-zindex-18616

Conversation

@siddeshgawande
Copy link
Copy Markdown

@siddeshgawande siddeshgawande commented May 27, 2026

Summary

Fixes an issue where zIndex applied to elements returned by renderItem was not respected by VirtualizedListCellRenderer, causing incorrect stacking order in FlatList/VirtualizedList items.

Changes

  • Add extractZIndexFromListItemElement to retrieve zIndex from the outermost element returned by renderItem.
  • Support Fragment children by extracting the maximum zIndex among Fragment descendants.
  • Hoist extracted zIndex onto the cell wrapper style so sibling cells render in the correct stacking order.
  • Preserve existing inversion and layout styles using StyleSheet.compose.
  • Add unit tests covering:
    • direct root element zIndex
    • style array flattening
    • Fragment children
    • absence of zIndex
    • custom CellRendererComponent support

Fixes #18616

Changelog:

[General] [Fixed] - Preserve zIndex from renderItem elements in VirtualizedListCellRenderer

Test Plan

  • Added unit tests for zIndex extraction behavior.
  • Verified zIndex is correctly applied for:
    • direct root elements
    • Fragment children
    • style arrays
    • custom CellRendererComponent usage
  • Ran VirtualizedList test suite successfully.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 27, 2026

Hi @siddeshgawande!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 27, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 27, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zIndex in a List

1 participant