Add StatusBar "auto" barStyle value#56978
Open
zoontek wants to merge 3 commits into
Open
Conversation
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
|
@zeyap has imported this pull request. If you are a Meta employee, you can view this in D106535143. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds support for
barStyle="auto"onStatusBar. When set, the bar style is resolved against the current color scheme:light-contentin dark mode,dark-contentin light mode. The resolution re-runs when the system color scheme changes, while at least oneStatusBaris mounted.The behavior mirrors what
expo-status-baralready exposes. The'auto'name is the one we use at Expo. It is not necessarily the right name for React Native core, happy to switch to something else if reviewers prefer.Changelog:
[GENERAL] [ADDED] - StatusBar: support
barStyle="auto"to follow the current color schemeTest Plan:
yarn jest packages/react-native/Libraries/Components/StatusBarpasses, including a new test that assertssetBarStyle('auto')calls the native module withdark-contentin light mode andlight-contentin dark mode.