Skip to content

fix(ios): make Podfile.lock SPEC CHECKSUMS deterministic across machines #56977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IsaacIsrael wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −6
Open

fix(ios): make Podfile.lock SPEC CHECKSUMS deterministic across machines #56977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/yoga/Yoga.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@ Pod::Spec.new do |spec|
# Fabric must be able to access private headers (which should not be included in the umbrella header)
all_header_files = 'yoga/**/*.h'
all_header_files = File.join('ReactCommon/yoga', all_header_files) if ENV['INSTALL_YOGA_WITHOUT_PATH_OPTION']
spec.private_header_files = Dir.glob(all_header_files) - Dir.glob(public_header_files)
spec.private_header_files = Dir.glob(all_header_files).sort - Dir.glob(public_header_files).sort
spec.preserve_paths = [all_header_files]
end
6 changes: 1 addition & 5 deletions packages/react-native/sdks/hermes-engine/hermes-engine.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,8 @@ Pod::Spec.new do |spec|
# When using the local prebuilt tarball, it should include hermesc compatible with the used VM.
# In other cases, the prebuilt versioned Hermes V1 hermesc binaries from the hermes-compiler npm package can be used.
if source_type != HermesEngineSourceType::LOCAL_PREBUILT_TARBALL
hermes_compiler_path = File.dirname(Pod::Executable.execute_command('node', ['-p',
"require.resolve(\"hermes-compiler\", {paths: [\"#{react_native_path}\"]})", __dir__]).strip
)

spec.user_target_xcconfig = {
'HERMES_CLI_PATH' => "#{hermes_compiler_path}/hermesc/osx-bin/hermesc"
'HERMES_CLI_PATH' => '$(PODS_ROOT)/../../node_modules/hermes-compiler/hermesc/osx-bin/hermesc'
Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

his won't work with RNTester because RNTester doesn't have an iOS folder. This assumes that the structure is always:

app
|-> node_modules
|-> ios
    |-> Pods

But many apps might have different setups and layouts.

}
end

Expand Down
Loading