Expose Event, EventTarget and CustomEvent as globals#56416
Open
rubennorte wants to merge 1 commit intofacebook:mainfrom
Open
Expose Event, EventTarget and CustomEvent as globals#56416rubennorte wants to merge 1 commit intofacebook:mainfrom
rubennorte wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Registers Event, EventTarget and CustomEvent as global polyfills in `setUpDOM.js`. These are standard Web APIs that DOM nodes need access to. Removes the Event/EventTarget polyfills from the Fantom test setup since they are now provided globally by setUpDOM.js. Changelog: [internal] Marking as internal for now, until we ship to stable, even though this isn't gated. We shouldn't communicate this yet. Differential Revision: D100462548
meta-cla
bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100462548. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Registers Event, EventTarget and CustomEvent as global polyfills in
setUpDOM.js. These are standard Web APIs that DOM nodes need access to.Removes the Event/EventTarget polyfills from the Fantom test setup since they are now provided globally by setUpDOM.js.
Changelog: [internal]
Marking as internal for now, until we ship to stable, even though this isn't gated. We shouldn't communicate this yet.
Differential Revision: D100462548