fix RCTBundleURLProvider crash when failing to check isPackagerRunning#55761
Open
vzaidman wants to merge 1 commit intofacebook:mainfrom
Open
fix RCTBundleURLProvider crash when failing to check isPackagerRunning#55761vzaidman wants to merge 1 commit intofacebook:mainfrom
vzaidman wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: In certain situations, where there are network issues reaching the Dev Server, the app crashes because of waiting too long on a semaphore. Instead, reduce the timeout on the `/status` request to 6 seconds, which is plenty of time to validate that the Dev Server is running, and reduce the timeout for the semaphore to 8 seconds, in case the request still won't finish by then. Changelog: [iOS][Fixed] not crashing on network issues with connecting to DevServer Differential Revision: D94382277
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In certain situations, where there are network issues reaching the Dev Server, the app crashes because of waiting too long on a semaphore.
Instead, reduce the timeout on the
/statusrequest to 6 seconds, which is plenty of time to validate that the Dev Server is running, and reduce the timeout for the semaphore to 8 seconds, in case the request still won't finish by then.Changelog: [iOS][Fixed] not crashing on network issues with connecting to DevServer
Differential Revision: D94382277