Use std::ranges::reverse_view and enable clang-tidy reverse ranges#55755
Open
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Open
Use std::ranges::reverse_view and enable clang-tidy reverse ranges#55755NickGerleman wants to merge 1 commit intofacebook:mainfrom
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Previously, the RN build in fbcode was using an old platform version with poor support for std::ranges, so we had disabled clang-tidy's `modernize-loop-convert.UseCxx20ReverseRanges` check. This is no longer the case, so we can remove the suppression and replace instances of reverse iteration using rbegin/rend iterators with `std::ranges::reverse_view`. Changelog: [Internal] Differential Revision: D75834622
NickGerleman
force-pushed
the
export-D75834622
branch
from
c033db7 to
75e674c
Compare
meta-cla
bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D75834622. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, the RN build in fbcode was using an old platform version with poor support for std::ranges, so we had disabled clang-tidy's
modernize-loop-convert.UseCxx20ReverseRangescheck. This is no longer the case, so we can remove the suppression and replace instances of reverse iteration using rbegin/rend iterators withstd::ranges::reverse_view.Changelog: [Internal]
Differential Revision: D75834622