Skip to content

Rename template type not to collide with existing identifier #55741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
+10 −10
Closed

Rename template type not to collide with existing identifier #55741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/react-native/ReactCommon/react/renderer/css/CSSList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,22 @@

namespace facebook::react {

template <CSSMaybeCompoundDataType T, CSSDelimiter Delim>
template <CSSMaybeCompoundDataType T, CSSDelimiter Delimeter>
struct CSSList;

template <CSSDataType AllowedTypeT, CSSDelimiter Delim>
struct CSSList<AllowedTypeT, Delim> : public std::vector<AllowedTypeT> {};
template <CSSDataType AllowedTypeT, CSSDelimiter Delimeter>
struct CSSList<AllowedTypeT, Delimeter> : public std::vector<AllowedTypeT> {};

template <CSSValidCompoundDataType AllowedTypesT, CSSDelimiter Delim>
struct CSSList<AllowedTypesT, Delim> : public std::vector<AllowedTypesT> {};
template <CSSValidCompoundDataType AllowedTypesT, CSSDelimiter Delimeter>
struct CSSList<AllowedTypesT, Delimeter> : public std::vector<AllowedTypesT> {};

template <CSSMaybeCompoundDataType AllowedTypeT, CSSDelimiter Delim>
struct CSSDataTypeParser<CSSList<AllowedTypeT, Delim>> {
static inline auto consume(CSSValueParser &parser) -> std::optional<CSSList<AllowedTypeT, Delim>>
template <CSSMaybeCompoundDataType AllowedTypeT, CSSDelimiter Delimeter>
struct CSSDataTypeParser<CSSList<AllowedTypeT, Delimeter>> {
static inline auto consume(CSSValueParser &parser) -> std::optional<CSSList<AllowedTypeT, Delimeter>>
{
CSSList<AllowedTypeT, Delim> result;
CSSList<AllowedTypeT, Delimeter> result;
for (auto nextValue = parser.parseNextValue<AllowedTypeT>(); !std::holds_alternative<std::monostate>(nextValue);
nextValue = parser.parseNextValue<AllowedTypeT>(Delim)) {
nextValue = parser.parseNextValue<AllowedTypeT>(Delimeter)) {
// Copy from the variant of possible values to the element (either the
// concrete type, or a variant of compound types which exlcudes the
// possibility of std::monostate for parse error)
Expand Down
Loading