Skip to content

fix Hover shows @NNN at SQLAlchemy type pos #3240#4113

Open
asukaminato0721 wants to merge 1 commit into
facebook:mainfrom
asukaminato0721:3240
Open

fix Hover shows @NNN at SQLAlchemy type pos #3240#4113
asukaminato0721 wants to merge 1 commit into
facebook:mainfrom
asukaminato0721:3240

Conversation

@asukaminato0721

Copy link
Copy Markdown
Contributor

Summary

Fixes #3240

Constructor hover types are resolved before rendering, preventing internal @NNN variables from leaking:

Test Plan

add test

@github-actions

Copy link
Copy Markdown

Diff from mypy_primer, showing the effect of this PR on open source code:

apprise (https://github.com/caronc/apprise)
- ERROR apprise/plugins/vapid/__init__.py:356:20-43: Object of class `dict` has no attribute `load` [missing-attribute]
- ERROR apprise/plugins/vapid/__init__.py:391:16-22: `not in` is not supported between `object` and `WebPushSubscriptionManager` [unsupported-operation]
- ERROR apprise/plugins/vapid/__init__.py:405:28-65: Argument `EllipticCurvePublicKey | Unknown | None` is not assignable to parameter `public_key` with type `EllipticCurvePublicKey` in function `apprise.utils.pem.ApprisePEMController.encrypt_webpush` [bad-argument-type]
- ERROR apprise/plugins/vapid/__init__.py:405:47-53: Cannot index into `WebPushSubscriptionManager` [bad-index]
- ERROR apprise/plugins/vapid/__init__.py:406:29-67: Argument `bytes | Unknown | None` is not assignable to parameter `auth_secret` with type `bytes` in function `apprise.utils.pem.ApprisePEMController.encrypt_webpush` [bad-argument-type]
- ERROR apprise/plugins/vapid/__init__.py:406:48-54: Cannot index into `WebPushSubscriptionManager` [bad-index]
- ERROR apprise/plugins/vapid/__init__.py:609:42-70: Argument `bytes | None` is not assignable to parameter `data` with type `bytes` in function `apprise.utils.base64.base64_urlencode` [bad-argument-type]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hover shows @NNN at SQLAlchemy type pos

1 participant