fix Insert import with alias creates invalid import #2495#4106
Closed
asukaminato0721 wants to merge 2 commits into
Closed
fix Insert import with alias creates invalid import #2495#4106asukaminato0721 wants to merge 2 commits into
asukaminato0721 wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
kinto0
reviewed
Jul 10, 2026
This comment has been minimized.
This comment has been minimized.
kinto0
requested changes
Jul 14, 2026
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
@kinto0 has imported this pull request. If you are a Meta employee, you can view this in D111934167. |
yangdanny97
approved these changes
Jul 14, 2026
yangdanny97
left a comment
yangdanny97
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2495
Auto-import resolution now preserves the original exported name and generates
from model import MyModel as MyModelAlias.Unknown-name quick fixes receive the same alias-aware behavior.
Test Plan
add test