enh: suppress false-positive unknown-name errors after short-circuit boolean ops#3588
Open
MarcoGorelli wants to merge 1 commit into
Open
enh: suppress false-positive unknown-name errors after short-circuit boolean ops#3588MarcoGorelli wants to merge 1 commit into
MarcoGorelli wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, in a check like
,
unknown-nameis raised forA, even though it's not reached. This came up in Polars, where there's a variable defined based on the Polars version, butraises
The idea is that, if a boolean expression short-circuits based on an always-true statement (if the boolean expression is
or) or an always-false one (if the boolean expression isand), then the code after it is unreachable and sounknown-nameshouldn't be reportedThe check for short-circuiting needs to be done:
values.next)values)AI disclosure: I used some assistance from Claude
Fixes #3554
Test Plan
This PR includes tests. The mypy-primer also shows no effects