Skip to content

fix(examples): sync example Node.js versions with templates and generation workflow#12121

Open
DhineshPonnarasan wants to merge 1 commit into
facebook:mainfrom
DhineshPonnarasan:fix-examples-sync-node-version
Open

fix(examples): sync example Node.js versions with templates and generation workflow#12121
DhineshPonnarasan wants to merge 1 commit into
facebook:mainfrom
DhineshPonnarasan:fix-examples-sync-node-version

Conversation

@DhineshPonnarasan

@DhineshPonnarasan DhineshPonnarasan commented Jun 7, 2026

Copy link
Copy Markdown

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Summary

The generated example artifacts at examples/ contain values that are out of sync with the current template definitions and generation workflow:

  • Engine field in package.json files still requires ">=20.0", while the local templates at packages/create-docusaurus/templates/ specify ">=24.14".
  • Sandbox node version in sandbox.config.json files still specifies "18", while the generation script at admin/scripts/generateExamples.js emits "24".

The examples are generated from the published create-docusaurus package. At the time of the last regeneration, the published package produced values that differ from the current local templates and generation workflow.

This PR updates the checked-in example artifacts so they are consistent with the current template definitions and the values emitted by admin/scripts/generateExamples.js.

No regeneration was performed as part of this change; only the stale values in the generated artifacts were updated.

Changes

  • examples/classic/package.json — engine ">=20.0"">=24.14"
  • examples/classic-typescript/package.json — engine ">=20.0"">=24.14"
  • examples/classic/sandbox.config.json — node version "18""24" (two occurrences)
  • examples/classic-typescript/sandbox.config.json — node version "18""24" (two occurrences)

Verification

  • 4 files changed
  • 6 insertions, 6 deletions
  • All values now match template definitions and generation workflow

Issue

Closes #12120

…#12120)

The example artifacts were regenerated for the v3.10.1 maintenance
release, which reverted the engine field from '>=24.14' back to
'>=20.0' and left the sandbox node version at '18'.

Update the examples to reflect current maintainer intent:
- Bump engines.node from '>=20.0' to '>=24.14'
  (reapplies PR facebook#11914 change overwritten by PR facebook#11985)
- Bump sandbox.config.json node from '18' to '24'
  (syncs with generateExamples.js updated in PR facebook#12080)
@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label Jun 7, 2026
@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm @pnpm/network.ca-file is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: ?npm/@pnpm/network.ca-file@1.0.2

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@pnpm/network.ca-file@1.0.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@netlify

netlify Bot commented Jun 7, 2026

Copy link
Copy Markdown

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit da762b7
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6a24bed7dcd02b000809e93e
😎 Deploy Preview https://deploy-preview-12121--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated example artifacts contain stale Node.js versions

1 participant