Add INFO status to HealthcheckStatus enum#4952
Open
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Open
Add INFO status to HealthcheckStatus enum#4952shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Add a new INFO status level to HealthcheckStatus for healthchecks that are working as expected but have useful information to display to the user. This is Phase 1 of the healthcheck status redesign. The INFO status represents a "positive passing" state where we want to surface helpful information (e.g., early stopping savings, baseline improvements) without indicating any problem. Changes: - Add INFO = 3 to HealthcheckStatus enum - Update is_passing() to return True for both PASS and INFO statuses Differential Revision: D94411963
meta-cla
bot
added
the
CLA Signed
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94411963. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4952 +/- ##
=======================================
Coverage 96.83% 96.83%
=======================================
Files 594 594
Lines 62894 62895 +1
=======================================
+ Hits 60903 60904 +1
Misses 1991 1991 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new INFO status level to HealthcheckStatus for healthchecks that are working as expected but have useful information to display to the user.
This is Phase 1 of the healthcheck status redesign. The INFO status represents a "positive passing" state where we want to surface helpful information (e.g., early stopping savings, baseline improvements) without indicating any problem.
Changes:
Differential Revision: D94411963