Rename parallelism to concurrency in Client and AxClient APIs#4923
Closed
mgrange1998 wants to merge 1 commit intofacebook:mainfrom
Closed
Rename parallelism to concurrency in Client and AxClient APIs#4923mgrange1998 wants to merge 1 commit intofacebook:mainfrom
mgrange1998 wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 20, 2026
…ok#4923) Summary: Pull Request resolved: facebook#4923 Renames the `parallelism` parameter to `concurrency` in `Client.run_trials()` and adds backward-compatible deprecated `max_parallelism` parameters in `AxClient.create_experiment()` and `AxClient.get_max_parallelism()` → `get_max_concurrency()`. Both include deprecation warnings guiding callers to use the new parameter names, with validation that old and new parameters are not specified simultaneously. Differential Revision: D93771849
mgrange1998
force-pushed
the
export-D93771849
branch
from
e90fb76 to
dae8837
Compare
|
@mgrange1998 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93771849. |
mgrange1998
force-pushed
the
export-D93771849
branch
2 times, most recently
from
cd5857d to
9adbad0
Compare
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 26, 2026
…ok#4923) Summary: Renames `AxClient.get_max_parallelism()` to `get_max_concurrency()` and updates internal variable names, comments, and docstrings to use "concurrency" terminology. The old `get_max_parallelism` is preserved as a deprecated stub raising `NotImplementedError`. Also updates `get_recommended_max_parallelism` to point to the new name, and imports `MaxParallelismReachedException` / `MaxGenerationParallelism` under concurrency-named aliases. `get_max_parallelism` is only used directly in ad-hoc notebooks, making this a low-risk rename Differential Revision: D93771849
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 26, 2026
…ok#4923) Summary: Renames `AxClient.get_max_parallelism()` to `get_max_concurrency()` and updates internal variable names, comments, and docstrings to use "concurrency" terminology. The old `get_max_parallelism` is preserved as a deprecated stub raising `NotImplementedError`. Also updates `get_recommended_max_parallelism` to point to the new name, and imports `MaxParallelismReachedException` / `MaxGenerationParallelism` under concurrency-named aliases. `get_max_parallelism` is only used directly in ad-hoc notebooks, making this a low-risk rename Differential Revision: D93771849
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 26, 2026
…ok#4923) Summary: Renames `AxClient.get_max_parallelism()` to `get_max_concurrency()` and updates internal variable names, comments, and docstrings to use "concurrency" terminology. The old `get_max_parallelism` is preserved as a deprecated stub raising `NotImplementedError`. Also updates `get_recommended_max_parallelism` to point to the new name, and imports `MaxParallelismReachedException` / `MaxGenerationParallelism` under concurrency-named aliases. `get_max_parallelism` is only used directly in ad-hoc notebooks, making this a low-risk rename Differential Revision: D93771849
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 26, 2026
…ok#4923) Summary: Renames `AxClient.get_max_parallelism()` to `get_max_concurrency()` and updates internal variable names, comments, and docstrings to use "concurrency" terminology. The old `get_max_parallelism` is preserved as a deprecated stub raising `NotImplementedError`. Also updates `get_recommended_max_parallelism` to point to the new name, and imports `MaxParallelismReachedException` / `MaxGenerationParallelism` under concurrency-named aliases. `get_max_parallelism` is only used directly in ad-hoc notebooks, making this a low-risk rename Reviewed By: saitcakmak Differential Revision: D93771849
mgrange1998
force-pushed
the
export-D93771849
branch
from
9adbad0 to
8deeb62
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4923 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 597 597
Lines 63664 63668 +4
=======================================
+ Hits 61664 61668 +4
Misses 2000 2000 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ok#4923) Summary: Renames `AxClient.get_max_parallelism()` to `get_max_concurrency()` and updates internal variable names, comments, and docstrings to use "concurrency" terminology. The old `get_max_parallelism` is preserved as a deprecated stub raising `NotImplementedError`. Also updates `get_recommended_max_parallelism` to point to the new name, and imports `MaxParallelismReachedException` / `MaxGenerationParallelism` under concurrency-named aliases. `get_max_parallelism` is only used directly in ad-hoc notebooks, making this a low-risk rename Reviewed By: saitcakmak Differential Revision: D93771849
mgrange1998
force-pushed
the
export-D93771849
branch
from
8deeb62 to
f142664
Compare
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Mar 4, 2026
…ok#4923) Summary: Renames `AxClient.get_max_parallelism()` to `get_max_concurrency()` and updates internal variable names, comments, and docstrings to use "concurrency" terminology. The old `get_max_parallelism` is preserved as a deprecated stub raising `NotImplementedError`. Also updates `get_recommended_max_parallelism` to point to the new name, and imports `MaxParallelismReachedException` / `MaxGenerationParallelism` under concurrency-named aliases. `get_max_parallelism` is only used directly in ad-hoc notebooks, making this a low-risk rename Reviewed By: saitcakmak Differential Revision: D93771849
|
This pull request has been merged in 357f9eb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Renames the
parallelismparameter toconcurrencyinClient.run_trials()and adds backward-compatible deprecatedmax_parallelismparameters inAxClient.create_experiment()andAxClient.get_max_parallelism()→get_max_concurrency(). Both include deprecation warnings guiding callers to use the new parameter names, with validation that old and new parameters are not specified simultaneously.Differential Revision: D93771849