New preference to enable/disable analysis upon open or save manifest …#734
Open
johnsteele wants to merge 1 commit intofabric8-analytics:mainfrom
Open
New preference to enable/disable analysis upon open or save manifest …#734johnsteele wants to merge 1 commit intofabric8-analytics:mainfrom
johnsteele wants to merge 1 commit intofabric8-analytics:mainfrom
Conversation
johnsteele
force-pushed
the
master
branch
3 times, most recently
from
f62acc7 to
67ec35a
Compare
…ifest documents. Signed-off-by: John Steele <programjsteele@gmail.com>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 98.97% 98.47% -0.50%
==========================================
Files 13 13
Lines 390 394 +4
Branches 52 54 +2
==========================================
+ Hits 386 388 +2
Misses 3 3
- Partials 1 3 +2 ☔ View full report in Codecov by Sentry. |
ruromero
reviewed
Mar 7, 2025
Collaborator
ruromero
left a comment
ruromero
left a comment
There was a problem hiding this comment.
@johnsteele this seems like a very reasonable option to allow users disable the analysis each time a manifest file is saved but as it is a breaking change I would suggest to enable it by default.
ruromero
force-pushed
the
master
branch
3 times, most recently
from
0ed5f8f to
7d96fcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…documents.