[Beam] Unify receive overloads and fix String.Compare codegen#4363
Merged
[Beam] Unify receive overloads and fix String.Compare codegen#4363
Conversation
Change Erlang.receive from two separate functions (receive/receiveForever) to overloaded static methods on a type, and move String.Compare dispatch from inline emitted case expressions to a fable_string:compare/3 library function to eliminate Erlang compiler warnings about unreachable clauses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Erlangfrom a module withreceive/receiveForeverto a type with overloaded staticreceivemethods —receive<'T>(timeoutMs)returns'T option,receive<'T>()blocks forever and returns'Tfable_string:compare/3library function, eliminating erlc warnings about unreachable clauses caused by mixing boolean and integer patterns in the samecaseexpressioncompare/3handles allStringComparisonignore-case variants (1, 3, 5) plus thetrueboolean overload via Erlang pattern matchingTest plan
./build.sh test beam)string_tests.erl"clause cannot match" warnings are gone🤖 Generated with Claude Code