Reject empty keypaths separator#580
Open
CodingFeng101 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
keypaths(..., separator="")now raises the sameValueErroras other invalid separators instead of silently falling back to the default"."separator.Why
The function documents and reports that the separator must be a non-empty string. An explicit empty separator is most likely a caller mistake, and silently converting it to
"."can hide the invalid input and return keypaths with an unexpected separator.separator=Nonestill preserves the previous default behavior.Validation
python -m pytest tests\core\test_keypaths.py -qpython -m pytest tests\core -qpython -m ruff check benedict\core\keypaths.py tests\core\test_keypaths.pypython -m black --check benedict\core\keypaths.py tests\core\test_keypaths.pygit diff --check