Skip to content

Add Docker support and change configuration to be taken from env vars#2

Open
grigal wants to merge 22 commits intof1shl:mainfrom
grigal:main
Open

Add Docker support and change configuration to be taken from env vars#2
grigal wants to merge 22 commits intof1shl:mainfrom
grigal:main

Conversation

@grigal
Copy link
Copy Markdown

@grigal grigal commented Apr 1, 2024

  • Added docker support
  • Configuration from environment variables
  • Required configuration validation
  • Removed unneeded dependencies
  • Added logging to console, rather than file

@f1shl
Copy link
Copy Markdown
Owner

f1shl commented May 11, 2024

Thanks for the Docker integration!
Why not leaving the Config file as an additional method to set the necessary parameters?
With the docker container, environment variables makes totally sense!

@FrancYescO
Copy link
Copy Markdown

maybe just replace the .ini file with a .env and load it from py for who still want to run without docker

@ducphu0ng
Copy link
Copy Markdown

Is there any update? Since I haven't seen the PR merged, I wrote my own Docker-based script to avoid differences in outcomes across systems. If you're interested, you can check it out here: https://github.com/ducphu0ng/imap-netflix-household-automation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants