fix(release): harden publish artifact handoff#66
Merged
Conversation
Normalize downloaded CI AOT artifact envelopes before WASIX publish validation. Allow publish and publish-dry-run to target an explicit release commit while running the latest release tooling, with CI artifact gates and release-please tags anchored to that commit. Keep GitHub release asset uploads immutable by failing on conflicting bytes instead of exposing an overwrite switch.
7c470bd to
7d4127f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release_commitworkflow input for publish and publish-dry-run: it resolves a full SHA, requires it to be on currentmain, allows only release-tooling changes between the release commit and workflow commit, and uses the selected SHA for planning, CI gates, artifact downloads, publishing, and verification.release_commitdiffers from the workflow commit.Validation
bash -n .github/scripts/resolve-release-head.sh .github/scripts/download-wasix-runtime-build-artifacts.sh .github/scripts/download-build-artifacts.sh .github/scripts/require-workflow-success.shpython3 -m py_compile tools/release/release.py tools/release/upload_github_release_assets.py tools/policy/check-release-policy.py tools/release/check_artifact_targets.py tools/release/check_release_metadata.pypython3 tools/policy/check-release-policy.pytools/policy/check-workflows.shpython3 tools/release/check_artifact_targets.pybun tools/policy/assertions/assert-ci-workflows.mjstools/release/release.py checktools/release/sync_release_pr.py --checkcargo test -p xtaskgit diff --checkpython3 tools/release/upload_github_release_assets.py --helppython3 tools/release/release.py publish --help