Persist floating window size and position between sessions - #91
Open
robert-corlett wants to merge 1 commit into
Open
Persist floating window size and position between sessions#91robert-corlett wants to merge 1 commit into
robert-corlett wants to merge 1 commit into
Conversation
The floating overlay was always recreated at a centered default frame, so any manual resize or reposition was lost when the session ended. The panel frame is stored in NotchSettings whenever the window is moved or resized, and the panel is constructed with that frame so the content lays out against its final size immediately. The saved size is restored as-is; only the origin is constrained, so the window cannot come back with an edge past the display, and a frame whose center no longer lands on a connected display is discarded in favour of the default. The stored frame is marked @ObservationIgnored: nothing renders from it, and it is written on every drag and resize step, which would otherwise redraw the overlay continuously while the window is being dragged.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds persistence to the floating window size and position - see issue #90
The floating overlay was always recreated at a centered default frame, so any manual resize or reposition was lost when the session ended.
The panel frame is stored in NotchSettings whenever the window is moved or resized, and the panel is constructed with that frame so the content lays out against its final size immediately. The saved size is restored as-is; only the origin is constrained, so the window cannot come back with an edge past the display, and a frame whose center no longer lands on a connected display is discarded in favour of the default.
The stored frame is marked @ObservationIgnored: nothing renders from it, and it is written on every drag and resize step, which would otherwise redraw the overlay continuously while the window is being dragged.