Skip to content

Return kill() result #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PNHD wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return kill() result #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24f07bf
fix: return kill result
PNHD Aug 14, 2026
b4fd48c
test: cover kill return value
PNHD Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,11 +448,11 @@ export class PythonShell extends EventEmitter {

/**
* Sends a kill signal to the process
* @returns {PythonShell} The same instance for chaining calls
* @returns {boolean} Whether the kill signal was sent successfully
*/
kill(signal?: NodeJS.Signals) {
this.terminated = this.childProcess.kill(signal);
return this;
return this.terminated;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions test/test-python-shell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,9 +617,9 @@ describe('PythonShell', function () {
});

describe('.kill()', function () {
it('set terminated to correct value', function (done) {
it('return kill result and set terminated to correct value', function (done) {
let pyshell = new PythonShell('infinite_loop.py');
pyshell.kill();
should(pyshell.kill()).be.true();
pyshell.terminated.should.be.true;
done();
});
Expand Down