Conversation
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
Thank you so much, love these contributions 👍 I just had a couple comments.
bilby91
force-pushed
the
add-typescript-defintions
branch
3 times, most recently
from
68b88a0 to
480c31f
Compare
|
Please tell me when you're done force pushing. Every time I try to make a comment the page reload and everything I typed is lost. |
|
@dougwilson Sorry for that, it was tricky to get it working for old version of npm that don't support scoped modules. I think travis should fine now. |
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
I haven't finished my review as the force pushed kept erasing what I was typing. I have to get going now, so wanted to at least post what I was able to get saved.
bilby91
force-pushed
the
add-typescript-defintions
branch
3 times, most recently
from
5f71207 to
856eec7
Compare
bilby91
force-pushed
the
add-typescript-defintions
branch
from
856eec7 to
6de1130
Compare
|
I think it should be good now @dougwilson |
|
Ping @dougwilson |
|
I'm trying to get someone on my side who knows TypeScript to review this still. |
|
This has been a year, can this get merged? I'll buy someone a beer, or fly and hug you. K thanks :) |
|
Ping @dougwilson |
|
i made a fork refactored in typescript https://github.com/PabloSzx/vhost-ts https://www.npmjs.com/package/vhost-ts but for now it only handles express types (open for PRs) it also includes #21 |
|
Ping @dougwilson |
|
I'm doing some cleanup of my PRs and I'm no longer going to work on this one. |
5 participants
No description provided.