Skip to content

fix: keep footer social icons from shrinking below 16px#2458

Open
Hashim1999164 wants to merge 1 commit into
expressjs:mainfrom
Hashim1999164:fix/footer-social-icons-min-size-2456
Open

fix: keep footer social icons from shrinking below 16px#2458
Hashim1999164 wants to merge 1 commit into
expressjs:mainfrom
Hashim1999164:fix/footer-social-icons-min-size-2456

Conversation

@Hashim1999164

@Hashim1999164 Hashim1999164 commented Jul 22, 2026

Copy link
Copy Markdown

Summary

  • Prevent footer social icons from shrinking on narrow viewports when the Kawaii toggle shares the same flex row
  • Pin icons to 16px and keep a usable hit area on the links
  • Allow the social row to wrap instead of compressing items

Fixes #2456

Test plan

  • Open the site footer at a viewport under 400px wide
  • Confirm social icons stay at least 16px and do not collapse beside the Kawaii button
  • Confirm icons remain clickable and the Kawaii toggle still works
  • Spot-check desktop footer layout is unchanged

On narrow viewports the Kawaii toggle shared a flex row with social
icons, and the global svg max-width rule let them shrink. Prevent
shrink/wrap instead, pin icons to 16px, and keep a usable hit area.

Fixes expressjs#2456
@Hashim1999164
Hashim1999164 requested a review from a team as a code owner July 22, 2026 23:15
@netlify

netlify Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 89f3f9c
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/6a614f1a01e3f90008d55c47
😎 Deploy Preview https://deploy-preview-2458--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

footer: kawaii button shrinking social icons below 400px

1 participant