docs: add TypeScript section to application generator page#2372
Closed
sapirbaruch wants to merge 2 commits into
Closed
docs: add TypeScript section to application generator page#2372sapirbaruch wants to merge 2 commits into
sapirbaruch wants to merge 2 commits into
Conversation
The generator docs never mentioned TypeScript. Add a short TypeScript section pointing to the community `express-generator-typescript` project, for both 4x and 5x English docs. Addresses expressjs/express#7231
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The OpenJS Foundation Slack invite URL redirects to a rotating Slack invite token. Lychee follows the redirect and gets a 403 from Slack's bot-protection, causing 1618 false-positive link errors across every page that renders the footer. Adding the vanity domain to .lycheeignore silences the noise without removing the link from the site.
Contributor
|
Duplicate of #2311 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses expressjs/express#7231.
The Express application generator docs page never mentions TypeScript, even though it's a very common request. This adds a short TypeScript section that points readers to the community-maintained
express-generator-typescriptproject, with a clear note that it's third-party and not maintained by the Express team.Added to both the 4x and 5x English docs:
src/content/docs/en/4x/starter/generator.mdxsrc/content/docs/en/5x/starter/generator.mdxNon-English pages are left untouched since they're managed via Crowdin.
Test plan
npm run buildcompletes successfully (1232 pages built)/en/4x/starter/generator/and/en/5x/starter/generator/(headingid="typescript", code block, and the GitHub link all present in the built HTML)npx prettier --checkpasses on both edited files