fix: clarify differences in res.jsonp() behavior and security measures#2366
Open
spiderocious wants to merge 1 commit into
Open
fix: clarify differences in res.jsonp() behavior and security measures#2366spiderocious wants to merge 1 commit into
spiderocious wants to merge 1 commit into
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
res.jsonpAPI reference says the method is "identical tores.json(), except that it opts-in to JSONP callback support". As discussed in #1330, that's understating things: when the callback query parameter is present,res.jsonpalso forces theContent-Typetotext/javascript(and per @dougwilson's confirmation, this can't be overridden because no other content type will execute as JSONP in a browser), addsX-Content-Type-Options: nosniff, and prefixes the body with/**/as a security mitigation against the Rosetta Flash JSONP attack.Fix
Replace the misleading "identical" line with a short bulleted description of the actual differences, in both the 4x and 5x API references. The existing examples and "jsonp callback name" override section are unchanged.
closes #1330