fix(res.send): preserve bytes when sending DataView - #7433
Open
bun-unsafe wants to merge 1 commit into
Open
Conversation
DataView is an ArrayBuffer view but has no .length, so the binary path produced an empty body with HTTP 200. Copy via byteOffset/byteLength.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
res.send(new DataView(buffer))returned HTTP 200 withContent-Length: 0and an empty body.res.send(new Uint8Array(buffer))on the same bytes sent the payload.ArrayBuffer.isViewis true for DataView, so the value is treated as binary. The length path then useschunk.length/Buffer.from(chunk, encoding). DataView has no.length(only.byteLength), andBuffer.from(dataView)is an empty Buffer.This copies non-Buffer views with
Buffer.from(view.buffer, view.byteOffset, view.byteLength). ExistingBufferandUint8Arraybehavior is unchanged.This does not change bare
ArrayBuffer(still sent as{}JSON). That is covered by #7362.Tests:
test/res.send.jsfor a full DataView and a sliced DataView.