fix: treat QUERY method as cacheable in req.fresh#7367
Closed
muhamedfazalps wants to merge 1 commit into
Closed
Conversation
QUERY (RFC 10008) is a safe, idempotent, cacheable HTTP method. The req.fresh accessor short-circuits to false for any method other than GET or HEAD, so QUERY responses never get 304 Not Modified even when the client sends a matching If-None-Match header. This change adds QUERY to the set of methods that are eligible for freshness validation.
Contributor
|
Duplicate of #7366 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7365. QUERY (RFC 10008) is a safe, idempotent, cacheable HTTP method. All 1258 tests pass.