fix(req): ignore trailing dot in subdomains#7341
Closed
andrewkernel wants to merge 1 commit into
Closed
Conversation
Contributor
|
Duplicate of #7331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes
req.subdomainsfor fully qualified domain names that include a trailing dot. The trailing root label is now ignored before applying the configured subdomain offset, sotobi.ferrets.example.com.behaves the same astobi.ferrets.example.com.Why
Before this change, the trailing dot was treated as an empty DNS label. With the default subdomain offset, that shifted the result and returned
['example', 'ferrets', 'tobi']instead of['ferrets', 'tobi'].Changes
req.subdomainsgetter before splitting labelsTests
npx mocha --require test/support/env --reporter spec --check-leaks test/req.subdomains.jsnpm testnpm run lintgit diff --check HEAD~1..HEAD