fix: resolve #108 - exclude false/undefined signed cookies#162
Open
abhii734 wants to merge 1 commit intoexpressjs:masterfrom
Open
fix: resolve #108 - exclude false/undefined signed cookies#162abhii734 wants to merge 1 commit intoexpressjs:masterfrom
abhii734 wants to merge 1 commit intoexpressjs:masterfrom
Conversation
When cookie secret is changed, signed cookies signed with the old secret return false. These should not be included in signedCookies result as they are invalid, not just unsigned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (cookie-parser#108)
When cookie secret is changed, signed cookies that were signed with the old secret cannot be verified and
signedCookie()returnsfalse. The current code checksif (val !== dec)which is true even whendecisfalse, causing invalid signed cookies to be included in the result asfalse.Fix
Add additional check to exclude cookies with
falseorundefinedvalues from signed cookies result.Verification
req.signedCookies.csrf === falsereq.signedCookies.csrf === undefined(not included)