[scripts] Add runtime settings editor#3812
Open
sjchmiela wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3812 +/- ##
=======================================
Coverage 57.46% 57.46%
=======================================
Files 911 911
Lines 39480 39480
Branches 8271 8271
=======================================
Hits 22684 22684
Misses 15328 15328
Partials 1468 1468 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjchmiela
force-pushed
the
stanley/edit-runtime-settings
branch
from
4d34a71 to
daa24d9
Compare
sjchmiela
force-pushed
the
stanley/edit-runtime-settings
branch
from
daa24d9 to
4930081
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want us to move off of killswitches in Redis coming from
workflow-orchestrationtowards fetching killswitches from a simple JSON file.I picked GCS over R2 because it lets us make objects fully public (no
Authorizationrequired) and I (Stanley) found no way to achieve the same thing with R2.This pull request adds a script
scripts/edit-runtime-settings staging | productionthat is going to let us edit the file.