[build-tools] - handle sentry-cli upload failures as non-fatal#3808
Open
AbbanMustafa wants to merge 3 commits into
Open
[build-tools] - handle sentry-cli upload failures as non-fatal#3808AbbanMustafa wants to merge 3 commits into
AbbanMustafa wants to merge 3 commits into
Conversation
|
Subscribed to pull request
Generated by CodeMention |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3808 +/- ##
==========================================
- Coverage 57.46% 57.43% -0.02%
==========================================
Files 911 914 +3
Lines 39480 39572 +92
Branches 8271 8294 +23
==========================================
+ Hits 22684 22725 +41
- Misses 15328 15377 +49
- Partials 1468 1470 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
~500 builds fail per week that have the sentry-cli configured. Sentry sourcemap/dSYM upload failures can currently fail an otherwise successful build. These failures are often caused by Sentry configuration or transient upload issues, and Sentry already supports
SENTRY_ALLOW_FAILURE=truefor this case.How
Added a shared build-tools helper that sets
SENTRY_ALLOW_FAILURE=trueby default for build runs, unless Sentry upload behavior is already explicitly configured.The helper does not override:
SENTRY_ALLOW_FAILURESENTRY_DISABLE_AUTO_UPLOADEAS_BUILD_FAIL_ON_SENTRY_UPLOAD_ERROR=1Wired the helper into both native build paths:
Test Plan
Added build-tools tests: