Skip to content

[build-tools] Support absolute artifact glob paths#3788

Open
sjchmiela wants to merge 1 commit into
mainfrom
stanley/apply-absolute-artifact-globs
Open

[build-tools] Support absolute artifact glob paths#3788
sjchmiela wants to merge 1 commit into
mainfrom
stanley/apply-absolute-artifact-globs

Conversation

@sjchmiela
Copy link
Copy Markdown
Contributor

@sjchmiela sjchmiela commented May 22, 2026

See https://app.datadoghq.com/logs?query=findArtifacts&agg_m=count&agg_m_source=base&agg_q=status%2Cservice&agg_q_source=base%2Cbase&agg_t=count&clustering_pattern_field_path=message&cols=host%2Cservice&messageDisplay=inline&refresh_mode=sliding&sort_m=%2C&sort_m_source=%2C&sort_t=%2C&storage=hot&stream_sort=desc&top_n=10%2C10&top_o=top%2Ctop&viz=pattern&x_missing=true%2Ctrue&from_ts=1779570516711&to_ts=1779743316711&live=true


Summary

  • applies the validated absolute-glob artifact lookup behavior directly
  • keeps existing exact absolute path handling intact
  • adds unit coverage for absolute glob artifact patterns

Why

The dry-run Sentry instrumentation validated that absolute artifact glob support is the intended behavior. This PR removes the dry-run path and uses the supported lookup logic directly.

Validation

  • yarn oxfmt packages/build-tools/src/utils/artifacts.ts packages/build-tools/src/utils/tests/artifacts.test.ts
  • yarn --cwd packages/build-tools test --runTestsByPath src/utils/tests/artifacts.test.ts

@sjchmiela sjchmiela changed the title Support absolute artifact glob paths [build-tools] Support absolute artifact glob paths May 22, 2026
@sjchmiela sjchmiela marked this pull request as ready for review May 25, 2026 21:22
@sjchmiela sjchmiela force-pushed the stanley/apply-absolute-artifact-globs branch from bdae1ed to 6e8a60f Compare May 25, 2026 21:22
@github-actions
Copy link
Copy Markdown

ghost commented May 25, 2026

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label May 25, 2026
@sjchmiela sjchmiela requested a review from hSATAC May 25, 2026 21:24
@github-actions
Copy link
Copy Markdown

ghost commented May 25, 2026

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.20%. Comparing base (2fc5f20) to head (6e8a60f).

Files with missing lines Patch % Lines
packages/build-tools/src/utils/artifacts.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3788      +/-   ##
==========================================
- Coverage   57.22%   57.20%   -0.02%     
==========================================
  Files         905      905              
  Lines       39302    39276      -26     
  Branches     8237     8229       -8     
==========================================
- Hits        22488    22463      -25     
+ Misses      15344    15343       -1     
  Partials     1470     1470              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant