[eas-cli] improve naming for observe commands#3778
Conversation
|
Subscribed to pull request
Generated by CodeMention |
|
|
||
| ### 🛠 Breaking changes | ||
|
|
||
| - [eas-cli] Rename observe commands: `observe:logs` → `observe:events` (events emitted via `logEvent`), previous `observe:events` → `observe:metrics` (individual performance metric samples), previous `observe:metrics` → `observe:metric-summary` (aggregated stats by app version). ([#3778](https://github.com/expo/eas-cli/pull/3778) by [@kadikraman](https://github.com/kadikraman)) |
There was a problem hiding this comment.
This is a breaking change, but there isn't really a way around it, and that's why we're in preview, right!
I think adding this here will create a major version will mean a major version bump when publishing - is that ok or should I put it in another section?
| 'expo.app_startup.tti': 'Startup TTI', | ||
| 'expo.app_startup.ttr': 'Startup TTR', | ||
| 'expo.app_startup.bundle_load_time': 'Bundle Load', | ||
| 'expo.updates.download_time': 'Update Download', |
There was a problem hiding this comment.
Noticed this was missing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3778 +/- ##
==========================================
+ Coverage 56.83% 57.16% +0.33%
==========================================
Files 904 905 +1
Lines 39129 39284 +155
Branches 8178 8227 +49
==========================================
+ Hits 22237 22454 +217
+ Misses 15420 15358 -62
Partials 1472 1472 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ Thank you for adding the changelog entry! |
2 participants
Why
Part of ENG-21384
The naming of our CLI commands does not match the website.
How
observe:metrics->observe:metrics-summaryobserve:events->observe:metricsobserve:logs->observe:eventsTest Plan
Manual and automated testing