Conversation
143f0d9 to
cfe2bcd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3398 +/- ##
==========================================
- Coverage 52.30% 52.26% -0.03%
==========================================
Files 804 804
Lines 33421 33450 +29
Branches 6972 6975 +3
==========================================
+ Hits 17478 17480 +2
- Misses 14555 15885 +1330
+ Partials 1388 85 -1303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Subscribed to pull request
Generated by CodeMention |
tchayen
approved these changes
Feb 12, 2026
tchayen
reviewed
Feb 12, 2026
CHANGELOG.md
Outdated
|
|
||
| ### 🎉 New features | ||
|
|
||
| - Use authorization code flow with PKCE for browser-based login. ([#XXXX](https://github.com/expo/eas-cli/pull/XXXX) by [@byronkarlen](https://github.com/byronkarlen)) |
Contributor
Author
There was a problem hiding this comment.
Whoops thank you! (geez claude)
cfe2bcd to
4b6aafd
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Browser-based login should get a code and then exchange that code for a session_secret.
How
Used new auth flow provided by website/www. Uses state, code_challenge and code_verifier like OAuth 2.1.
Test Plan
Tested locally against expo.test with https://github.com/expo/universe/pull/24960
Made sure:
Tested against expo.dev as well. Tried to test SSO but was hard since our stub-idp doesn't save state/users.