Skip to content

Conversation

@EvanBacon
Copy link
Contributor

Summary

  • Fixes eas build --non-interactive prompting interactively when the project doesn't have git initialized
  • In non-interactive mode, automatically runs git init and creates an initial commit
  • Shows informative message: No git repository found. Auto initializing in /path. Set EAS_NO_VCS=1 to skip.
  • Improved error message when git user.name/email not configured to show exact commands to run

Test plan

  • Run eas build --non-interactive in a project without git initialized
  • Verify it auto-initializes git instead of prompting
  • Verify EAS_NO_VCS=1 eas build --non-interactive skips git initialization

🤖 Generated with Claude Code

Add an optional nonInteractive parameter to Client.ensureRepoExistsAsync and implement it in GitClient. When nonInteractive is true, GitClient will auto-init the repo (git init), create an initial commit, and surface a single error with suggested git config commands if user.name/email are missing. Update callers across build/update/inspect/configure commands to pass the appropriate nonInteractive flag and adjust ensureRepoIsCleanAsync calls. Also resolve the workspace root for init operations and improve related log messages.
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/commands/update/** @wschurman, @quinlanj
packages/eas-cli/src/commands/build/** @sjchmiela
packages/eas-cli/src/build/** @sjchmiela

Generated by CodeMention

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Size Change: -1.67 kB (0%)

Total Size: 72.7 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 72.7 MB -1.67 kB (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.29%. Comparing base (42940b7) to head (e9088db).

Files with missing lines Patch % Lines
packages/eas-cli/src/vcs/clients/git.ts 0.00% 18 Missing and 2 partials ⚠️
packages/eas-cli/src/commands/build/dev.ts 0.00% 2 Missing ⚠️
packages/eas-cli/src/build/runBuildAndSubmit.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/commands/build/configure.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/commands/build/inspect.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/commands/update/configure.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3387      +/-   ##
==========================================
- Coverage   52.31%   52.29%   -0.01%     
==========================================
  Files         804      804              
  Lines       33425    33437      +12     
  Branches     6975     6981       +6     
==========================================
  Hits        17482    17482              
- Misses      14555    14566      +11     
- Partials     1388     1389       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@douglowder douglowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In non-interactive mode, we should definitely not prompt. Thanks for fixing that! However, we should not execute a git operation under the hood. I'd prefer that we throw an error stating that the command requires a git repo.

@EvanBacon
Copy link
Contributor Author

@douglowder my thinking here is that git is pretty easy to delete and users can opt-out of this behavior by: a) having a git repo, or b) setting EAS_NO_VCS=1 which skips all git checks. I imagine we can pull this back a bit by skipping the auto git setup for commands that don't need git to operate (but I'm not sure which those are).

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants