Skip to content

Conversation

@sjchmiela
Copy link
Contributor

Why

Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.

How

How did you build this feature or fix this bug and why?

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

@sjchmiela sjchmiela force-pushed the stanley/move-to-oxlint branch from 7d9b6fc to bca50dc Compare February 6, 2026 10:59
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Size Change: -1.74 kB (0%)

Total Size: 72.7 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 72.7 MB -1.74 kB (0%)

compressed-size-action

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Feb 6, 2026
@sjchmiela sjchmiela force-pushed the stanley/move-to-oxlint branch from bca50dc to c302f0c Compare February 6, 2026 11:05
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela sjchmiela marked this pull request as ready for review February 6, 2026 11:24
@sjchmiela sjchmiela requested a review from douglowder February 6, 2026 11:24
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/commands/update/** @wschurman, @quinlanj
packages/eas-cli/src/worker/** @kitten, @kadikraman

Generated by CodeMention

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.30%. Comparing base (d29a88e) to head (c302f0c).

Files with missing lines Patch % Lines
...-cli/src/utils/pollForBackgroundJobReceiptAsync.ts 69.24% 6 Missing and 2 partials ⚠️
packages/build-tools/src/common/eagerBundle.ts 0.00% 2 Missing ⚠️
packages/eas-cli/src/commands/update/index.ts 0.00% 1 Missing and 1 partial ⚠️
...src/steps/functions/findAndUploadBuildArtifacts.ts 0.00% 0 Missing and 1 partial ⚠️
packages/eas-cli/src/commands/config.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/ora.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3384      +/-   ##
==========================================
- Coverage   52.31%   52.30%   -0.00%     
==========================================
  Files         804      804              
  Lines       33423    33419       -4     
  Branches     6970     6967       -3     
==========================================
- Hits        17482    17478       -4     
  Misses      14553    14553              
  Partials     1388     1388              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@douglowder douglowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the changes in quotes needed? If not, it would be great to change the lint configuration so the PR is smaller. Also, there is no PR description…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants