Skip to content

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Jan 26, 2026

Why

This was temporarily removed in #3182. No discussion has occurred and none are planned so just removing the code for now since it's likely stale. If and when discussion happens we can just reference this PR to add it back in.

How

Remove code.

Test Plan

yarn tsc

@github-actions
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link
Member Author

wschurman commented Jan 26, 2026

@wschurman wschurman marked this pull request as ready for review January 26, 2026 17:06
@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/commands/update/** @quinlanj

Generated by CodeMention

@github-actions
Copy link

Size Change: +406 B (0%)

Total Size: 53.2 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.2 MB +406 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.67%. Comparing base (1c31702) to head (2915606).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3344   +/-   ##
=======================================
  Coverage   49.67%   49.67%           
=======================================
  Files         671      671           
  Lines       28018    28018           
  Branches     5802     5802           
=======================================
  Hits        13914    13914           
  Misses      12916    12916           
  Partials     1188     1188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman merged commit 4d04463 into main Jan 27, 2026
12 of 13 checks passed
@wschurman wschurman deleted the wschurman/01-26-_eas-cli_remove_commented-out_code_in_eas_update_command branch January 27, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants