fix(generator): handle list-typed nullable fields from upstream spec#93
Draft
natalie-o-perret wants to merge 1 commit into
Draft
fix(generator): handle list-typed nullable fields from upstream spec#93natalie-o-perret wants to merge 1 commit into
natalie-o-perret wants to merge 1 commit into
Conversation
The upstream Exoscale OpenAPI spec now emits type as a list for nullable fields (e.g. ["integer", "null"]), which is valid JSON Schema but was not handled by the generator. Added _translate_type() helper that normalizes both str and list type values. Also added a test verification step to the openapi.yaml auto-update workflow so master is no longer broken silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream Exoscale OpenAPI v2 spec now emits
typeas a listfor nullable fields, e.g.
"type": ["integer", "null"]. The codegenerator at
generator.py:74assumedtypeis always astr,causing
TypeError: unhashable type:list`` on import.Before (master): pytest collects 0 items, 2 errors
After (fix):
Changes:
_translate_type()helper ingenerator.pythat handles bothstrandlisttype values (list →"int | None")_type_translations[<expr>]call sites with_translate_type(<expr>)uv run pyteststep toopenapi.yamlauto-update workflow sospec changes are verified before committing to master
Note
AI-assisted for initial investigation and implementation.