fix(compute): adjust default disk size to template - #882
Draft
natalie-o-perret wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
[SC-186913] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
compute instance createandcompute instance-pool createdefault to a 50 GiB disk, but some templates require a larger disk. Using such a template without--disk-sizecurrently sends an invalid request.This change resolves the selected template before creation and:
Checklist
(For exoscale contributors)
CHANGELOG.md)Testing
Tested from PR head in
ch-dk-2with a 10 GiB Ubuntu template and an 80 GiB Anapaya template. All instances, pools, and temporary SSH keys created for these checks were deleted afterward.Default already large enough
The 50 GiB default is preserved without a warning for a 10 GiB template.
Default increased to template size
The implicit 50 GiB default is increased to 80 GiB and the adjustment is reported on stderr.
Explicit sufficient size preserved
An explicit size that can contain the template is used unchanged.
Explicit undersized value rejected
An explicit value smaller than the selected template fails before creating a resource.
The instance-pool command returns the same error before creation:
Instance Pool default increased
The same default adjustment is applied when creating an Instance Pool.
Note
AI assistance: test scaffolding, PR description.