-
-
Notifications
You must be signed in to change notification settings - Fork 59
Format all instructions.append.md to start with an H1 (required but ignored) and H2
#459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| # Instructions Append | ||
|
|
||
| ## Implementation | ||
|
|
||
| The anagrams can be returned in any order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| # Note | ||
| # Instructions append | ||
|
|
||
| ## Note | ||
|
|
||
| The tests for this problem assume that numbers are passed through without being encrypted/decrypted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| # Instructions append | ||
|
|
||
| In Racket, this exercise uses sorted [vectors] rather than lists because vectors support constant-time access of its elements. Like several other Lisp tracks, when an item isn't present in the vector, the expectation is that the [Boolean literal `#f`][booleans] will be returned rather than raising an exception. | ||
| ## Implementation | ||
|
|
||
| In Racket, this exercise uses sorted [vectors] rather than lists because vectors support constant-time access of its elements. | ||
| Like several other Lisp tracks, when an item isn't present in the vector, the expectation is that the [Boolean literal `#f`][booleans] will be returned rather than raising an exception. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wouldn't mention "several other Lisp tracks", and returning |
||
|
|
||
| [vectors]: https://docs.racket-lang.org/guide/vectors.html | ||
| [booleans]: https://docs.racket-lang.org/reference/booleans.html | ||
6 changes: 3 additions & 3 deletions
6
exercises/practice/perfect-numbers/.docs/instructions.append.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # Implementation | ||
| # Instructions append | ||
|
|
||
| Implement a procedure named `classify` that takes a number as argument and returns either `'perfect`, | ||
| `'abundant`, or `'deficient`. | ||
| ## Implementation | ||
|
|
||
| Implement a procedure named `classify` that takes a number as argument and returns either `'perfect`, `'abundant`, or `'deficient`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| # Note | ||
| # Instructions append | ||
|
|
||
| ## Note | ||
|
|
||
| For this problem, you will need to write the test. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"vectors provide constant-time access to their elements" or "a vector provides constant-time access to its elements" would be better. Maybe outside the scope of this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that append should be changed. Did you want to PR that separately? I'm on the fence about even mentioning constant-time access though since that's a big hint. The append is mainly needed so students don't assume they're working with lists even before they look at the test suite.