-
-
Notifications
You must be signed in to change notification settings - Fork 11
[Tooling, CI, & Tests] Upgrade to python 3.13 & fix related bugs #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BethanyG
wants to merge
13
commits into
main
Choose a base branch
from
upgrade-to-python-3.13
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adds new Python 3.13 representation files for all tests.
… the Ellipsis object. Updated parse params from python 11.5 to 13.5.
…n bodies that bbecome empty when the docstring is removed.
…nywhere there was an empty list for the function or class body. This corrects an error where the normalization that removes docstrings then produces invalid code where the docstring was the only valid expression for the class or function. - Added documentation notes for upcomming AST object depriciations in Python 3.14. Alsot commented specifically in the import list. - Modified the AssAssign visitor to insert an assigned value of None where a node had an AnnAssign without a value. This covers the bug where a DataClass or other Class or Function has its tupehint removed, but had no default value when written. Dataclasses and other parsing steps at runtime assign these values, but the written code does not. Our normalization process removes the typehint, so produces invalid code. Assigning the value to None during parsing avoids this probblem. Since normalization is for grouping purposes only and does not produce executable code, this was considered a valid change.
…ed code changes and new cases.
Member
Author
|
DO NOT MERGE AT THIS TIME. This will need to be merged all at once with changes to the runner, the analyzer, and the content repo. Please also note that the number of files here is due to having to re-run tests results for Python 3.13, and there were changes to both normalization and ast representation. Those test files not noted in the last 13 code commits need not be reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python:3.13.5-alpine3.22as Python container version inDockerfile.requirements.txtanddev-requirements.txtPython 3.13ast changes. Addedclasstest case and updated others.